Re: Exposing PG_VERSION_NUM in pg_config

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Exposing PG_VERSION_NUM in pg_config
Date: 2015-03-29 10:53:42
Message-ID: CAB7nPqRLjSo4FhYoBkuArqULmH-9EeDKufe+UtNMLbmjTOtddw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 25, 2015 at 2:32 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Mar 25, 2015 at 8:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hm. We're all agreed that there's a use case for exposing PG_VERSION_NUM
>> to the makefiles, but I did not hear one for adding it to pg_config; and
>> doing the former takes about two lines whereas adding a pg_config option
>> entails quite a lot of overhead (documentation, translatable help text,
>> yadda yadda). So I'm not in favor of doing the latter without a much
>> more solid case than has been made.
>
> Well, I have no other cases than ones of the type mentioned upthread,
> and honestly I am fine as long as we do not apply maths to a version
> string. So attached is a patch that adds VERSION_NUM in
> Makefile.global.

Added entry in CF 2015-06 to not have this stuff fall into the void:
https://commitfest.postgresql.org/5/203/
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-03-29 10:59:46 Re: Rounding to even for numeric data type
Previous Message Michael Paquier 2015-03-29 10:21:25 Re: Rounding to even for numeric data type