| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: jacana hung after failing to acquire random number |
| Date: | 2016-12-12 07:44:26 |
| Message-ID: | CAB7nPqRHvzxp3gufPMqRYKemqk8Ye_NVBD6SHu+BdKy=tF_iqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 12, 2016 at 4:32 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> That test is broken. It looks like the x"$VAR" = x"constant" idiom, but the left side of the comparison doesn't have the 'x'. Oops.
Good catch.
> This makes me wonder if we should work a bit harder to get a good error
> message, if acquiring a random number fails for any reason. This needs to
> work in the frontend as well backend, but we could still have an elog(LOG,
> ...) there, inside an #ifndef FRONTEND block.
Yeah, this has been itching me as well. We could allocate an error
string in a psprintf()'d string and let the callers of
pg_strong_backend() use it as they are responsible for the error
handling. What do you think?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-12-12 07:46:38 | Re: Hang in pldebugger after git commit : 98a64d0 |
| Previous Message | Heikki Linnakangas | 2016-12-12 07:32:22 | Re: jacana hung after failing to acquire random number |