Re: Supporting src/test/modules in MSVC builds

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Supporting src/test/modules in MSVC builds
Date: 2015-04-16 23:42:26
Message-ID: CAB7nPqRBKKuHNnphGCgvPEk8Cx5sdU-WsoXZ1NBahNg9wYTXUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 17, 2015 at 4:47 AM, Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>> It looks good, and if you've tested it I'm satisfied. I suggest that
>> we apply patches 1 and 2 immediately. AUIU they don't require any
>> changes to the buildfarm, as the MSVC build process will automatically
>> build and install it with these changes.
>
> Okay, I just pushed patches 1 and 2.

Cool, thanks.

>> Then if all goes well we can apply the third patch and I'll fix the
>> buildfarm client for the forthcoming release to run the tests on MSVC
>> builds. Nothing will break in the meantime - the tests just won't get
>> run until the new client version is deployed.
>
> Will wait for a day or so to see what the Win buildfarm members say.

currawong and mastodon seem satisfied.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-04-16 23:49:09 Re: Supporting src/test/modules in MSVC builds
Previous Message Tom Lane 2015-04-16 23:36:21 Re: FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?