| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control |
| Date: | 2016-09-28 04:44:44 |
| Message-ID: | CAB7nPqR9Erm1hMvE82jWLsGAVKeviUZEm-ovdaPshJvNZ3TtOw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 27, 2016 at 9:55 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Seems overcomplicated to me. How about returning the control file all
> the time and let the caller pfree the result? You could then use
> crc_ok in pg_ctl.c's get_control_dbstate() to do the decision-making.
In short I would just go with the attached and call it a day.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| control-crc-checks-v2.patch | application/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2016-09-28 09:25:37 | pgsql: Turn password_encryption GUC into an enum. |
| Previous Message | pgsql | 2016-09-27 23:24:45 | pgsql: Tag refs/tags/REL9_6_0 was created |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2016-09-28 05:13:42 | Re: Transactions involving multiple postgres foreign servers |
| Previous Message | Amit Khandekar | 2016-09-28 04:30:08 | Re: asynchronous execution |