| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |
| Date: | 2015-07-28 06:30:07 |
| Message-ID: | CAB7nPqR8JTZ0n--UN9zAqf2CdNHJspLgZS=aRS_Cjyj-xfA4Ww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jul 28, 2015 at 3:11 PM, Heikki Linnakangas wrote:
> On 07/28/2015 02:54 AM, Michael Paquier wrote:
>> The problem is that state->max_block_id gets reset to -1 each time a
>> new record is read via ResetDecoder. Hence if we decode a record that
>> has block data and then if a second record that does not contain block
>> data is decoded, we will leak if XLogReaderFree is called because no
>> attempts will be made to pfree what has been allocated. Per se the
>> patch attached.
>
>
> Ok, committed. I hope we got it right this time..
Thanks! There is nothing more on radar now, so I am closing the issue
on the open item list.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sushant Sinha | 2015-07-28 06:34:58 | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |
| Previous Message | Heikki Linnakangas | 2015-07-28 06:11:34 | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |