From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Vladimir Rusinov <vrusinov(at)google(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
Date: | 2016-12-27 03:15:44 |
Message-ID: | CAB7nPqR7SwBKo8UmZ8=wEkCseFFdU4sAjys1se9Gq1+2R=ODYQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Dec 15, 2016 at 8:51 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Dec 15, 2016 at 1:20 AM, Vladimir Rusinov <vrusinov(at)google(dot)com> wrote:
>>> Personally, I think this is not important, but if you want to do it, I'd
>>> follow the suggestion in the thread to rename all functions and leave
>>> the old names as aliases or wrappers of some kind.
>>
>> I think I agree with Michael Paquier: "Better to do breakages in a single
>> release rather than spreading them across releases.".
>> There's going to be a lot of broken scripts following pg_xlog rename, so I
>> think it makes sense to just drop functions as well.
>
> For consistency that makes sense in my view. But I won't be too noisy
> as well if people think that we should keep aliases for compatibility.
Actually, I am changing my mind on this bit, following Peter's
opinion. Maintaining aliases of the past functions is a no-brainer,
and it has no cost in terms of maintenance. That will save much pain
to many monitoring scripts as well.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Dmitry Dolgov | 2016-12-27 03:23:29 | Re: [PATCH] Generic type subscription |
Previous Message | Kyotaro HORIGUCHI | 2016-12-27 03:11:18 | Re: BUG: pg_stat_statements query normalization issues with combined queries |