| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls |
| Date: | 2015-12-28 13:33:23 |
| Message-ID: | CAB7nPqR-Atxm_QkX0kX5Og0HQ5wg4-vXpFUDtGZU1Pka9oiG3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 28, 2015 at 5:07 PM, Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> wrote:
> Hello,
>
> at PostgreSQL version 9.5rc1,
> at line 934 in pg_recvlogical.c
>
> set_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
>
> this references invalid catalog file, because pg_basebackup,
> pg_recvlogical, pg_receivexlog commands use same catalog file
> pg_basebackup.mo
>
> pg_receivexlog.c too.
>
> patch please.
Yes, you are right. Both values do not match CATALOG_NAME in nls.mk. I
guess that something like the attached is fine then... The other
binaries are fine.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20151228_catalog_name_fix.patch | text/x-patch | 952 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-12-28 13:54:09 | Re: request patch pg_recvlogical.c, pg_receivexlog.c for nls |
| Previous Message | Michael Paquier | 2015-12-28 13:21:19 | pg_upgrade tests running calling psql without --no-psqlrc |