| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minor issues in pg_rewind |
| Date: | 2015-06-11 01:21:59 |
| Message-ID: | CAB7nPqR+wJtTxrFh26_EDBpnbVS6Khv97e7zVEK5_vr4izdacA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 11, 2015 at 2:38 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> * Remove invalid option character "N" from the third argument (valid option
> string) of getopt_long().
> * Use pg_free() or pfree() to free the memory allocated by pg_malloc() or
> palloc() instead of always using free().
> * Assume problem is no disk space if write() fails but doesn't set errno.
> * Fix several typos.
This looks good to me, especially the ENOSPC enforcement for
pg_control. We may want to rename datapagemap_iterate to
datapagemap_init as well. I can't really see what iterate means in
this context.
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2015-06-11 02:16:34 | Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1 |
| Previous Message | Amit Langote | 2015-06-11 01:15:13 | Re: [idea] table partition + hash join |