| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: passwordcheck: Add test suite |
| Date: | 2017-09-15 03:02:13 |
| Message-ID: | CAB7nPqQy7Zq152EQiFTE8=fkmHU5srePkkFPH8fhOHBvsWeKPA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> passwordcheck: Add test suite
>
> Also improve one error message.
>
> Reviewed-by: David Steele <david(at)pgmasters(dot)net>
Sorry for showing up late for this topic.
+REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
+REGRESS = passwordcheck
+# disabled because these tests require setting shared_preload_libraries
+NO_INSTALLCHECK = 1
You could have avoided all that by just issuing "load
'passwordcheck';" at the beginning of the test. And you gain support
for installcheck this way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-09-15 03:03:21 | pgsql: Remove TupleDesc remapping logic from tqueue.c. |
| Previous Message | Peter Eisentraut | 2017-09-15 02:46:06 | pgsql: chkpass: Add test suite |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-09-15 03:03:21 | pgsql: Add support for coordinating record typmods among parallel worke |
| Previous Message | Peter Eisentraut | 2017-09-15 02:47:21 | Re: additional contrib test suites |