| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: initdb: "'" for QUOTE_PATH (non-windows) |
| Date: | 2016-08-20 13:26:32 |
| Message-ID: | CAB7nPqQxC+Za0e8whuWAeusUx+aZGZdtF-haM6qJpCrY8jB2GA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 20, 2016 at 4:39 AM, Ryan Murphy <ryanfmurphy(at)gmail(dot)com> wrote:
> Here is another version of my initdb shell quoting patch. I have removed
> the unnecessary {} block. I also ran pgindent on the code prior to creating
> the patch.
Could you please *not* top-post? This breaks the logic of the thread,
this is the third time that I mention it, and that's not the style of
this mailing list.
Regarding your patch, with a bit of clean up it gives the attached.
You should declare variables at the beginning of a code block or
function. One call to appendPQExpBufferStr can as well be avoided, and
you added too many newlines. I have switched that as ready for
committer.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| initdb-path-v4.patch | application/x-download | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-08-20 13:41:32 | Re: LSN as a recovery target |
| Previous Message | Craig Ringer | 2016-08-20 13:24:47 | [PATCH] Transaction traceability - txid_status(bigint) |