Re: forward vs backward slashes in msvc build code

On Sun, Apr 26, 2015 at 10:29 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 04/25/2015 08:01 PM, Michael Paquier wrote:
>>
>> On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan <andrew(at)dunslane(dot)net>
>> wrote:
>>>
>>> On 04/25/2015 10:53 AM, Michael Paquier wrote:
>>>>
>>>> On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote:
>>>>>
>>>>> On 4/24/15 12:22 AM, Michael Paquier wrote:
>>>>>>
>>>>>> Now that the stuff related to the move from contrib/ to src/bin/,
>>>>>> modulescheck and tmp_install has been committed, shouldn't we give a
>>>>>> new shot at this patch? Attached is a rebased version.
>>>>>
>>>>> done
>>>>
>>>> Thanks, bowerbird is running fine:
>>>>
>>>>
>>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-25%2013%3A31%3A06
>>>
>>>
>>>
>>> But currawong is not - it runs an older version of the MS build tools.
>>> See
>>>
>>> <http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-25%2016%3A31%3A12>:
>>>
>>> Bad format filename 'src/backend/access/brin/brin.c'
>>> at src/tools/msvc/VCBuildProject.pm line 73.
>>> VCBuildProject::WriteFiles(VC2008Project=HASH(0x9a7274),
>>> "*Project::F") called at src/tools/msvc/Project.pm line 363
>>> Project::Save(VC2008Project=HASH(0x9a7274)) called at
>>> src/tools/msvc/Solution.pm line 539
>>> Solution::Save(VS2008Solution=HASH(0xc00b7c)) called at
>>> src/tools/msvc/Mkvcbuild.pm line 656
>>> Mkvcbuild::mkvcbuild(HASH(0xbed464)) called at build.pl line 36
>>
>> Oops, attached is a patch that should make currawong happier..
>
>
> OK, pushed.

Argh. This is not enough:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-26%2006%3A00%3A01
The build is done in Debug mode, but it is failing to find some files
under the label Release, which is incorrect. I guess that this is
caused by the file detection in WriteFiles... TBH I don't have an
environment at hand to reproduce the issue and do a proper fix. Hence
I think that we should revert the patch for now, and come back to this
stuff later on.
Regards,
--
Michael