| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys. |
| Date: | 2016-04-14 11:41:41 |
| Message-ID: | CAB7nPqQvLv5Bw+F8EdLF6nK8X=szq2R3EqtQ+5MiX5t=-jRNpw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 14, 2016 at 5:17 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, Apr 14, 2016 at 1:22 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Yes. I'd prefer avoid a hardcoded sleep and have something that relies
>> on lookups of pg_stat_replication though, because there is no way to
>> be sure that a sleep will ever be stable on heavily loaded machines,
>> like the machines I am specialized in maintaining :)
>> It kills a bit the purpose on having checks on pg_stat_replication as
>> the validation tests are based on that, still I think that we had
>> better base those checks on a loop that has a timeout, something like
>> that in a subroutine:
>> What do you think?
>
> Look good to me. +1.
And so here we go...
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| nsync-test-fix.patch | text/x-patch | 827 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-14 13:44:26 | pgsql: Fix prototype of pgwin32_bind(). |
| Previous Message | Masahiko Sawada | 2016-04-14 08:17:43 | Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2016-04-14 11:49:08 | Re: Odd system-column handling in postgres_fdw join pushdown patch |
| Previous Message | Michael Paquier | 2016-04-14 11:30:33 | Re: Why doesn't src/backend/port/win32/socket.c implement bind()? |