| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Header and comments describing routines in incorrect shape in visibilitymap.c |
| Date: | 2016-07-06 02:28:19 |
| Message-ID: | CAB7nPqQsQVZbuyjtkGdb5csry-bcp740G2oMPNcQz3yzx4t0xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
I just bumped into a couple of things in visibilitymap.c:
- visibilitymap_clear clears all bits of a visibility map, its header
comment mentions the contrary
- The header of visibilitymap.c mentions correctly "a bit" when
referring to setting them, but when clearing, it should say that all
bits are cleared.
- visibilitymap_set can set multiple bits
- visibilitymap_pin can be called to set up more than 1 bit.
This can be summed by the patch attached.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| vm-comments-fix.patch | text/x-diff | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-07-06 02:43:11 | Re: Documentation fixes for pg_visibility |
| Previous Message | Etsuro Fujita | 2016-07-06 02:18:38 | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |