From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: recovery_target_time = 'now' is not an error but still impractical setting |
Date: | 2017-08-17 05:05:30 |
Message-ID: | CAB7nPqQrnU2MsFsOckR5M0FuJoQxMpAewOzpbSW_VzeP1CEfAg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 17, 2017 at 1:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> -1 ... every datatype I/O function is entitled to assume it's being
> invoked inside a transaction. I do not think we should break that
> on a case-by-case basis. So using timestamptz_in directly in xlog.c
> was a bad idea, and we need to rethink that.
[evil mode]
Why not just calling SetCurrentStatementStartTimestamp() before
parsing the timestamp? A bit hacky, but I think that it would work.
[/evil mode]
> Not sure offhand how to mechanize that given the current code
> structure. We don't want to duplicate all the infrastructure
> used by timestamptz_in, certainly ... but how much of that
> code is depending in some way on being inside a transaction?
> I doubt that this issue with "now" is the only soft spot.
tomorrow, today, etc are other things.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2017-08-17 05:07:45 | Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90 |
Previous Message | Ashutosh Bapat | 2017-08-17 04:56:53 | Re: expanding inheritance in partition bound order |