Re: pgsql: Error out in pg_rewind if lstat() fails.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Error out in pg_rewind if lstat() fails.
Date: 2015-04-16 01:17:42
Message-ID: CAB7nPqQqym60VgjMvZS5Q25PJ1aanAVqzD1rkxyyxepZuySv1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Error out in pg_rewind if lstat() fails.
>
> A "file not found" is expected if the source server is running, so don't
> complain about that. But any other error is definitely not expected.

Nitpicking: strings of pg_fatal need to have a newline '\n' for readability.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2015-04-16 01:26:21 Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/
Previous Message Heikki Linnakangas 2015-04-15 20:15:33 pgsql: Minor cleanup of pg_rewind.