Re: Free indexed_tlist memory explicitly within set_plan_refs()

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date: 2015-05-25 02:45:30
Message-ID: CAB7nPqQqSd9zwKNKyFM-tGLe2=dF7HX91X5-c1kDapvvYL1XqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 25, 2015 at 10:17 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> While trying to fix a largely unrelated bug, I noticed that the new
> build_tlist_index() call for the "excluded" targetlist (used by ON
> CONFLICT DO UPDATE queries) does not have its memory subsequently
> freed by the caller. Since every other call to build_tlist_index()
> does this, and comments above build_tlist_index() encourage it, I
> think the new caller should do the same.
>
> Attached patch adds such a pfree() call.

Yep. This looks correct to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2015-05-25 07:12:35 Re: problems on Solaris
Previous Message Bruce Momjian 2015-05-25 01:52:49 Re: Run pgindent now?