| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Oskari Saarenmaa <os(at)ohmu(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] configure: allow adding a custom string to PG_VERSION |
| Date: | 2013-11-19 02:26:01 |
| Message-ID: | CAB7nPqQp4yE=3NXL7Gd1YJb1dWjL9ffrmDQM76WO9yQmY-Cc2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 19, 2013 at 10:48 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> I think this is a reasonable feature, and the implementation is OK, but
> I don't see why the format of the extra version information needs to be
> exactly
>
> PG_VERSION="$PACKAGE_VERSION ($withval)"
>
> I'd imagine, for example, that someone will want to do -something or
> +something. So I'd just make this
>
> PG_VERSION="$PACKAGE_VERSION$withval"
>
> Comments?
It makes sense and brings more flexibility. So +1 for this modification.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Johnston | 2013-11-19 02:30:32 | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |
| Previous Message | KONDO Mitsumasa | 2013-11-19 02:12:41 | Re: Improvement of pg_stat_statement usage about buffer hit ratio |