Re: Request - repeat value of \pset title during \watch interations

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Request - repeat value of \pset title during \watch interations
Date: 2016-01-28 13:01:03
Message-ID: CAB7nPqQk3V5kUqBGWu8eY7sTDWxq+fo6Kbfi8gE95zqyo4M6qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Thu, Jan 28, 2016 at 1:54 PM, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> On Wed, Jan 27, 2016 at 9:13 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>>
>> On Thu, Jan 28, 2016 at 9:34 AM, David G. Johnston
>> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>> > So how about:
>> >
>> > + snprintf(title, strlen(myopt.title) + 50,
>> > + _("Watch every %lds\t%s\t%s"),
>> > + sleep, head_title, asctime(localtime(&timer)));
>>
>> I would just keep the timestamp and the title separated so what do you
>> think about that instead?
>> Watch every Xs $timestamp
>> $head_title
>
>
> That works. I like having the title immediately above the table.
>
> The other option that came to mind would be to place the time information
> after the table display while leaving the title before it. On an output
> that requires more vertical space than is available in the terminal one
> would no longer have to scroll up to confirm last execution time. If doing
> this I'd probably get rid of any logic that attempts to center the time
> information on the table and simply leave it left-aligned.

OK, attached is an updated patch. How does that look?
--
Michael

Attachment Content-Type Size
psql_watch_title-v2.patch text/x-diff 1.8 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Craig Ringer 2016-01-28 13:02:55 Re: Difference between UDR and BDR replication
Previous Message Kaushal Shriyan 2016-01-28 11:16:26 Difference between UDR and BDR replication

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2016-01-28 13:04:53 Re: Template for commit messages
Previous Message Robert Haas 2016-01-28 12:57:59 Re: Template for commit messages