| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Rosser Schwarz <rosser(dot)schwarz(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Patch: add --if-exists to pg_recvlogical |
| Date: | 2017-11-28 02:11:30 |
| Message-ID: | CAB7nPqQeTprwEO8PW8tk2DzVLDOL6HSzQ+y68QUiVAY6DDLq=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 29, 2017 at 10:06 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 9/22/17 15:31, Peter Eisentraut wrote:
>> I suggest you create a patch that focuses on the --create part.
>>
>> You can create a separate follow-on patch for the --start part if you
>> wish, but I think that that patch would be rejected.
>
> I have moved this entry to the next commit fest, awaiting your updated
> patch.
Still waiting for an update, and marked as returned with feedback. It
seems to me that your patch adds a couple of option interactions, so
this should be double-checked with exiting options and a set of TAP
tests should be added as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-11-28 02:18:48 | Re: [HACKERS] Useless code in ExecInitModifyTable |
| Previous Message | Michael Paquier | 2017-11-28 02:07:06 | Re: [HACKERS] PATCH: pgbench - break out timing data for initialization phases |