| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Removing #include "postgres.h" from a couple of headers |
| Date: | 2017-03-08 08:58:06 |
| Message-ID: | CAB7nPqQdOUKjNa8dmsCy1+NrsxSa8a3ev5jjHe1hB8esyMo2rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 8, 2017 at 5:55 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Over in another thread it was pointed out that a patch I submitted
> broke a project rule by including "postgres.h" in a header. Here is a
> patch to remove it from dsa.h where I made the same mistake, and also
> a case I found in bufmask.h by grepping.
>
> There are also instances in regcustom.h and snowball's header.h -- are
> those special cases?
--- a/src/include/access/bufmask.h
+++ b/src/include/access/bufmask.h
@@ -17,7 +17,6 @@
#ifndef BUFMASK_H
#define BUFMASK_H
-#include "postgres.h"
#include "storage/block.h"
#include "storage/bufmgr.h"
Oops. This really escaped me...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kuntal Ghosh | 2017-03-08 09:02:22 | Re: WAL Consistency checking for hash indexes |
| Previous Message | Thomas Munro | 2017-03-08 08:55:08 | Removing #include "postgres.h" from a couple of headers |