Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause
Date: 2017-11-30 00:59:09
Message-ID: CAB7nPqQd6jbTKaHdu4NC2wS7+AMJLMHuUyabuao_UWOgue68wg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 29, 2017 at 1:53 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> IIRC, this issue was debated at great length back when we first put
>> in foreign tables, because early drafts of postgres_fdw did what you
>> propose here, and we ran into very nasty problems. We eventually decided
>> that allowing remotely-determined column defaults was a can of worms we
>> didn't want to open. I do not think that GENERATED columns really change
>> anything about that. They certainly don't do anything to resolve the
>> problems we were contending with back then. (Which I don't recall the
>> details of; you'll need to trawl the archives. Should be somewhere early
>> in 2013, though, since we implemented that change in commit 50c19fc76.)
>
> So this gives a good reason to do nothing or return an error at
> postgres_fdw level for OVERRIDING?

Moving the patch to next CF as the discussion has not settled yet.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-11-30 01:01:54 Re: [HACKERS] JIT compiling expressions/deform + inlining prototype v2.0
Previous Message Petr Jelinek 2017-11-30 00:30:49 Re: [HACKERS] Issues with logical replication