| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rounding to even for numeric data type |
| Date: | 2015-05-09 13:17:19 |
| Message-ID: | CAB7nPqQb41oyYPiHi6gtqVq06pWyx3negQs-h01-ud-2Ro10Jw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 2, 2015 at 9:53 PM, Fabien COELHO wrote:
> Quick review: patches applies, make check is fine, all is well.
Thanks for the feedback, Fabien!
> All the casting tests could be put in "numeric.sql", as there are all
> related to numeric and that would avoid duplicating the values lists.
Not sure about that, the tests are placed here to be consistent with
for is done for float8.
> For the documentation, I would also add 3.5 so that rounding to even is even
> clearer:-)
Good idea. I reworked the example in the docs.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Precise-rounding-behavior-of-numeric-and-double-prec.patch | application/x-patch | 8.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-05-09 15:15:20 | Re: ALTER SYSTEM and ParseConfigFile() |
| Previous Message | Kohei KaiGai | 2015-05-09 12:57:20 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |