Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.
Date: 2017-05-19 04:51:35
Message-ID: CAB7nPqQafwnsKAZ9sv9D8wE_3HU6gge6L0QuPXp9yK=4-2oC1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke
<higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> wrote:
> The reason of this problem is that sending 'show transaction_read_only' is failed.
> 'show' must be in uppercase letters because the streaming replication protocol only accepts capital letters.
> In psql and libpq applications that do not use the streaming replication protocol, this error does not occur.
>
> The attached patch fixes this. This patch changes 'show transaction_read_only' to 'SHOW transaction_read_only'.

if (!PQsendQuery(conn,
- "show transaction_read_only"))
+ "SHOW transaction_read_only"))
Or perhaps the replication command parser could be made more flexible
with lower-case characters for replication commands?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-05-19 05:01:38 Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)
Previous Message Amit Langote 2017-05-19 04:40:49 Re: different column orders in regression test database