Re: Creating backup history files for backups taken from standbys

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Creating backup history files for backups taken from standbys
Date: 2017-09-01 03:56:29
Message-ID: CAB7nPqQ_xztoCQ0v5+6tSiDrHH5LnMtvj45ayMQyLyDJszNhgA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Aug 10, 2017 at 4:55 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, Aug 10, 2017 at 4:50 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Thu, Aug 10, 2017 at 9:45 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> Thank you for the patch. Regarding to creating the backup history file
>>> on stanbys, is there any difference from the patch posted on earlier
>>> thread?
>>
>> That's a rebased version on top of what has been applied, except that
>> I have fixed an incorrect comment and shuffled the code building the
>> WAL segment name for the stop position.
>
> Understood, I'll review this patch.

Here is an updated patch with refreshed documentation, as a result of
449338c which was discussed in thread
https://www.postgresql.org/message-id/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8966@pgmasters.net.
I am just outlining the fact that a backup history file gets created
on standbys and that it is archived.
--
Michael

Attachment Content-Type Size
standby-backup-history-v2.patch application/octet-stream 5.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2017-09-01 04:11:12 adding the commit to a patch's thread
Previous Message Michael Paquier 2017-09-01 03:40:56 Re: pgbench tap tests & minor fixes.