| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Creating backup history files for backups taken from standbys |
| Date: | 2017-09-18 23:14:21 |
| Message-ID: | 29e90d72-0050-bc74-28f0-ed822c6d14bd@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
On 8/31/17 11:56 PM, Michael Paquier wrote:
> Here is an updated patch with refreshed documentation, as a result of
> 449338c which was discussed in thread
> https://www.postgresql.org/message-id/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8966@pgmasters.net.
> I am just outlining the fact that a backup history file gets created
> on standbys and that it is archived.
The patch looks good overall. It applies cleanly and passes all tests.
One question. Do we want to create this file all the time (as written),
or only when archive_mode = always?
It appears that CleanupBackupHistory() will immediately remove the
history file when archive_mode != always so it seems useless to write
it. On the other hand the code is a bit simpler this way. Thoughts?
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-09-18 23:26:30 | Re: Creating backup history files for backups taken from standbys |
| Previous Message | Xin Zhang | 2017-09-18 22:50:57 | Commits don't block for synchronous replication |