popen and pclose redefinitions causing many warning in Windows build

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: popen and pclose redefinitions causing many warning in Windows build
Date: 2014-05-08 05:01:42
Message-ID: CAB7nPqQLKBPUJx6AwqB8bfNScuMGPXjo=VcZB2v-nDoyth0W2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

Since commit a692ee5, code compilation on windows is full of warnings
caused by the re-definitions of popen and pclose:
In file included from ../../../src/include/c.h:1028:0,
from ../../../src/include/postgres.h:47,
from analyze.c:25:
../../../src/include/port.h:312:0: warning: "popen" redefined [enabled
by default]
In file included from ../../../src/include/c.h:81:0,
from ../../../src/include/postgres.h:47,
from analyze.c:25:
c:\mingw64\bin\../lib/gcc/x86_64-w64-mingw32/4.7.0/../../../../x86_64-w64-mingw32/include/stdio.h:48
9:0: note: this is the location of the previous definition
In file included from ../../../src/include/c.h:1028:0,
from ../../../src/include/postgres.h:47,
from analyze.c:25:
../../../src/include/port.h:313:0: warning: "pclose" redefined
[enabled by default]
In file included from ../../../src/include/c.h:81:0,
from ../../../src/include/postgres.h:47,
from analyze.c:25
The patch attached fixes that.
Regards,
--
Michael

Attachment Content-Type Size
20140508_win_build_warnings.patch application/octet-stream 608 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-05-08 05:42:21 Compilation errors with mingw build caused by undefined optreset
Previous Message Craig Ringer 2014-05-08 04:19:26 Re: PGDLLEXPORTing all GUCs?