Re: RecoveryTargetTLI dead variable in XLogCtlData

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Cc: Masao Fujii <masao(dot)fujii(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: RecoveryTargetTLI dead variable in XLogCtlData
Date: 2016-07-18 06:48:51
Message-ID: CAB7nPqQEu3ps63Dpo=puozNOWmrFsPcy08YkfFA_aPhFh0vomg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 13, 2016 at 12:29 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> I just bumped into $subject, a variable that is never set and never used:
> --- a/src/backend/access/transam/xlog.c
> +++ b/src/backend/access/transam/xlog.c
> @@ -631,8 +631,6 @@ typedef struct XLogCtlData
> TimeLineID replayEndTLI;
> /* timestamp of last COMMIT/ABORT record replayed (or being replayed) */
> TimestampTz recoveryLastXTime;
> - /* current effective recovery target timeline */
> - TimeLineID RecoveryTargetTLI;

d57a9734 has missed this cleanup.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-07-18 07:17:29 heap_update() VM retry could break HOT?
Previous Message Michael Paquier 2016-07-18 05:34:50 Re: Regression tests vs existing users in an installation