Re: [COMMITTERS] pgsql: Change TAP test framework to not rely on having a chmod executab

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Change TAP test framework to not rely on having a chmod executab
Date: 2015-08-26 06:15:31
Message-ID: CAB7nPqQEMpHd1v7f=DmR1p9t0Anck8ENOMVdOJNxyxgGzCRVkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Aug 25, 2015 at 11:02 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 6/19/15 10:52 AM, Robert Haas wrote:
>> Change TAP test framework to not rely on having a chmod executable.
>>
>> This might not work at all on Windows, and is not ever efficient.
>>
>> Michael Paquier
>
> I came across this on an unrelated mission and noticed it was
> unnecessarily complicated. How about this patch instead?

I didn't know this one... Looking at the docs this would visibly work
at least down to 5.8.8, the docs saying that a list of files can be
passed to chmod:
http://perldoc.perl.org/5.8.8/functions/chmod.html
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2015-08-26 14:33:12 pgsql: 9.5 release notes: mention lack of char() sort improvements
Previous Message Joe Conway 2015-08-26 01:46:40 pgsql: Reestablish alignment of pg_controldata output.

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-08-26 06:30:25 Re: Foreign join pushdown vs EvalPlanQual
Previous Message Michael Paquier 2015-08-26 05:47:27 Re: Commitfest remaining "Needs Review" items