Re: Let's use libpq for everything

On Tue, Dec 23, 2014 at 5:53 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> I've merged this with latest changes in the master branch, and did some
> error handling fixes. Latest version is again attached here, and also
> available in github
> (https://github.com/hlinnaka/psqlodbc/tree/libpq-integration4)

Some minor comments after scanning the code:
1) The description below should be prepareParametersNoDesc.
+/*
+ * Process the original SQL query.
+ */
+RETCODE prepareParametersNoDesc(StatementClass *stmt)
+{
+ QueryParse query_org, *qp;
+ QueryBuild query_crt, *qb;
+
+inolog("prepareParametersNoSync\n");
2) In psqlodbc.vcproj, you can safely remove the references to USE_LIBPQ.
3) s/Extrace/Extract
ISTM that this code is clean, I haven't found flaws in the new logic
where code is replaced with libpq stuff.
Regards,
--
Michael