| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dereferenced pointers checked as NULL in btree_utils_var.c |
| Date: | 2015-01-28 00:47:35 |
| Message-ID: | CAB7nPqQDAwkMmtZt5EGONssjs19yJd=xiLD4EQWJbXdo9nfmRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 28, 2015 at 3:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So I'm fine with taking out both this documentation text and the dead
> null-pointer checks; but let's do that all in one patch not piecemeal.
> In any case, this is just cosmetic cleanup; there's no actual hazard
> here.
Attached is a patch with all those things done. I added as well an
assertion in gistKeyIsEQ checking if the input datums are NULL. I
believe that this is still useful for developers, feel free to rip it
out from the patch if you think otherwise.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150128_gist_nullchecks.patch | text/x-patch | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-28 00:51:20 | Re: basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe? |
| Previous Message | Robert Haas | 2015-01-28 00:25:07 | Re: pgaudit - an auditing extension for PostgreSQL |