Re: Backend crash on non-exclusive backup cancel

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, David Steele <david(at)pgmasters(dot)net>
Subject: Re: Backend crash on non-exclusive backup cancel
Date: 2017-03-15 06:28:03
Message-ID: CAB7nPqQD9X0Bbzqy4YyUT_xrxEseaHBJ6mghiA4VvJFVJCZ-5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Mar 15, 2017 at 12:27 AM, Anastasia Lubennikova
<lubennikovaav(at)gmail(dot)com> wrote:
> As far as I understand, in this thread were discussed two bugs of pg_stop_backup().
> Thanks to the clear descriptions above, I easily reproduced both of them.
>
> BUG#1:
> Server crashes on assertion on call of pg_stop_backup(false) after interrupted call of pg_stop_backup(false).
> TRAP: FailedAssertion("!(XLogCtl->Insert.nonExclusiveBackups > 0)", File: "xlog.c", Line: 10747)
>
> BUG#2:
> Failure to start an exclusive backup with the same name, if previous exclusive backup was stopped in another session.
>
> Both problems seem to be fixed with patch "backup-session-locks-fixes.patch".
> Speaking of the patch itself, I have a question: shouldn't we also update sessionBackupState
> in pg_stop_backup_callback() along with XLogCtl->Insert.exclusiveBackupState?

No, that's not necessary. sessionBackupState is not changed until the
code path where pg_stop_backup_callback() is active, and remains
unchanged until it gets deactivated.

> And couple of minor notes:
> 1) + * Routines to starting stop, and get status of a base backup
> Probably should be: + * Routines to start, stop and get status of a base backup
> And also this comment should be moved below the enum.
>
> 2) This is used in parallel of the shared memory status
> s/ in parallel of/ in parallel with

Agreed on both points.
--
Michael

Attachment Content-Type Size
backup-session-locks-fixes-v2.patch application/octet-stream 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter van Hardenberg 2017-03-15 06:29:35 Defaulting psql to ON_ERROR_ROLLBACK=interactive
Previous Message Kuntal Ghosh 2017-03-15 05:57:10 Re: WAL Consistency checking for hash indexes

Browse pgsql-bugs by date

  From Date Subject
Next Message Alastair James 2017-03-15 08:27:58 Differences in COUNT result when enabling parallel query
Previous Message Andres Freund 2017-03-14 20:55:24 Re: postgresql hanging/stuck