From: | Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net> |
Subject: | Re: Backend crash on non-exclusive backup cancel |
Date: | 2017-03-14 15:27:14 |
Message-ID: | 20170314152714.22419.22145.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
As far as I understand, in this thread were discussed two bugs of pg_stop_backup().
Thanks to the clear descriptions above, I easily reproduced both of them.
BUG#1:
Server crashes on assertion on call of pg_stop_backup(false) after interrupted call of pg_stop_backup(false).
TRAP: FailedAssertion("!(XLogCtl->Insert.nonExclusiveBackups > 0)", File: "xlog.c", Line: 10747)
BUG#2:
Failure to start an exclusive backup with the same name, if previous exclusive backup was stopped in another session.
Both problems seem to be fixed with patch "backup-session-locks-fixes.patch".
Speaking of the patch itself, I have a question: shouldn't we also update sessionBackupState
in pg_stop_backup_callback() along with XLogCtl->Insert.exclusiveBackupState?
And couple of minor notes:
1) + * Routines to starting stop, and get status of a base backup
Probably should be: + * Routines to start, stop and get status of a base backup
And also this comment should be moved below the enum.
2) This is used in parallel of the shared memory status
s/ in parallel of/ in parallel with
The new status of this patch is: Waiting on Author
From | Date | Subject | |
---|---|---|---|
Next Message | Wiler Coelho Jr. | 2017-03-14 17:32:56 | Error floating-point exception on postgresql installer |
Previous Message | Tom Lane | 2017-03-14 14:25:37 | Re: postmaster.c ,have a warning: pg_getnameinfo_all() failed |
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2017-03-14 15:30:25 | Re: scram and \password |
Previous Message | Tom Lane | 2017-03-14 15:22:01 | Re: Bug: timestamp without time zone column allows timestamptz default |