| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-12-02 23:27:32 |
| Message-ID: | CAB7nPqQBWGGHW3cA8MLfQ30w-uE9925xjzewCZZwmPBXevRPeA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 3, 2014 at 12:23 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Peter Geoghegan wrote:
>> On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> > Just a small thing I noticed while looking at pageinspect.sgml, the
>> > set of SQL examples related to BRIN indexes uses lower-case characters
>> > for reserved keywords. This has been introduced by 7516f52.
>> > Patch is attached.
>>
>> My nitpicky observation about pageinspect + BRIN was that the comments
>> added to the pageinspect SQL file for the SQL-callable function
>> brin_revmap_data() have a comment header style slightly inconsistent
>> with the existing items.
>
> Pushed.
Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-12-03 00:16:47 | Re: [REVIEW] Re: Compression of full-page-writes |
| Previous Message | Tom Lane | 2014-12-02 22:44:55 | Re: B-Tree support function number 3 (strxfrm() optimization) |