| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-12-02 15:23:04 |
| Message-ID: | 20141202152304.GM1737@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan wrote:
> On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Just a small thing I noticed while looking at pageinspect.sgml, the
> > set of SQL examples related to BRIN indexes uses lower-case characters
> > for reserved keywords. This has been introduced by 7516f52.
> > Patch is attached.
>
> My nitpicky observation about pageinspect + BRIN was that the comments
> added to the pageinspect SQL file for the SQL-callable function
> brin_revmap_data() have a comment header style slightly inconsistent
> with the existing items.
Pushed.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-12-02 15:23:15 | Re: On partitioning |
| Previous Message | Robert Haas | 2014-12-02 15:12:29 | Re: test_shm_mq failing on mips* |