Re: Do we need use more meaningful variables to replace 0 in catalog head files?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Hao Lee <mixtrue(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Do we need use more meaningful variables to replace 0 in catalog head files?
Date: 2016-11-09 05:03:48
Message-ID: CAB7nPqQB2bbZe8=-kLD+JNsoERyaL5=GyBcxZ=FY5aapgcvyjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 9, 2016 at 1:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I don't think we need "named constants", especially not
> manually-maintained ones. The thing that would help in pg_proc.h is for
> numeric type OIDs to be replaced by type names. We talked awhile back
> about introducing some sort of preprocessing step that would allow doing
> that --- ie, it would look into some precursor file for pg_type.h and
> extract the appropriate OID automatically. I'm too tired to go find the
> thread right now, but it was mostly about building the long-DATA-lines
> representation from something easier to edit.

You mean that I guess:
https://www.postgresql.org/message-id/4d191a530911041228v621286a7q6a98d9ab8a2ed734@mail.gmail.com
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-11-09 05:33:17 Adding in docs the meaning of pg_stat_replication.sync_state
Previous Message Michael Paquier 2016-11-09 05:01:07 Re: Dumb mistakes in WalSndWriteData()