Re: ICU support on Windows

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ICU support on Windows
Date: 2017-06-12 21:32:15
Message-ID: CAB7nPqQAKGuSQCAYgp-_8eoxUnNY7ueUOsQ7Lj=fDSn4A-NcHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 13, 2017 at 3:13 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Ashutosh Sharma wrote:
>> > I noticed that this only works if you use the "Win32" download of ICU,
>> > because the "Win64" download uses "lib64" paths. I'm not sure what the
>> > impact of this is in practice.
>>
>> Yes, that's right, Win64 download uses lib64 path and in my case i had
>> renamed lib64-> lib and bin64-> bin which i guess is not a right thing
>> to do. I think, we should allow Solution.pm to detect the platform and
>> make a decision on the library path accordingly. Attached patch does
>> that. Please have a look let me know your thoughts on this. Thanks.
>
> Uh, that's pretty odd. Is it something libicu-specific? Because I
> don't see any other occurrence of \lib64\ anywhere in the MSVC build
> scripts.

I do some low level packaging on Windows (libxml2, libxslt, etc.), and
the compilation code usually allows you to usually use the
installation paths you want. At the end using only lib/ looks more
generic to me, and I did the same renaming as Ashutosh after unzipping
their files. There is already "Program Files" and "Program Files
(x86)" to make such distinctions.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-06-12 21:35:25 Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)
Previous Message Andres Freund 2017-06-12 21:25:17 Re: Transactional sequence stuff breaks pg_upgrade