Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin
Date: 2016-11-10 05:08:55
Message-ID: CAB7nPqQ91+Uj2wR8UQNWe-2gEAp=naM_HsM2P1ir26LWBhe2mA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 9, 2016 at 9:33 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
> In brin_doupdate(line 290), REGBUF_STANDARD is used to register
> revmap buffer reference in WAL record. But, revmap buffer page doesn't
> have a standard page layout and it doesn't update pd_upper and
> pd_lower as well.
>
> Either we should register revmapbuf as following:
> XLogRegisterBuffer(1, revmapbuf, 0);

As this is not a standard buffer, let's do it this way. This issue has
been captured by the WAL consistency patch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2016-11-10 05:13:05 Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly
Previous Message Michael Paquier 2016-11-10 04:55:27 Re: WAL consistency check facility