Re: Patch: add psql tab completion for event triggers

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ian Barwick <ian(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: add psql tab completion for event triggers
Date: 2014-04-14 14:13:49
Message-ID: CAB7nPqQ4V4_iP_bM_nNZw8K+AEkFi+w=sMNMO3E=VwHeXEoY+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 14, 2014 at 9:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
>> Apologies again, that was ill-thought out. Revised patch attached with only
>> the additions related to event triggers, and the small fix for ALTER TRIGGER
>> mentioned above which ensures "RENAME TO" is applied only when "ALTER
>> TRIGGER <name> ON <sth>" was input; currently there is no check for a
>> preceding "ALTER", resulting in the spurious "RENAME TO" when completing
>> "CREATE EVENT TRIGGER".
>
> OK, committed.
>
> (I know this was submitted rather late, but I think we've often
> allowed tab-completion fixups at similar times in past releases, since
> they are quite mechanical. If anyone feels that I shouldn't have
> committed this, please advise.)
+1 for this change even if it came late in-game. Patch is
straight-forward, and this is always useful to have.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-04-14 14:18:50 Re: HEAD seems to generate larger WAL regarding GIN index
Previous Message Tom Lane 2014-04-14 13:53:00 Re: four minor proposals for 9.5