| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixing memory leak in pg_upgrade |
| Date: | 2015-01-10 12:16:46 |
| Message-ID: | CAB7nPqQ3eSDT9j9TMwPEbageyZk2xKReNibxx7fZrMrmx2dhLw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 10, 2015 at 2:27 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> so some memory is allocated, and has to be freed. I looked at avoiding
> the call to gen_db_file_maps() for old_db->rel_arr.nrels == 0, but there
> are checks in there comparing the old/new relation counts, so it can't
> be skipped. I also removed the unnecessary memory initialization.
Patch is fine IMO for its purpose.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-01-10 13:11:07 | Re: Transactions involving multiple postgres foreign servers |
| Previous Message | Dean Rasheed | 2015-01-10 11:12:07 | Re: INSERT ... ON CONFLICT UPDATE and RLS |