Re: Support for N synchronous standby servers - take 2

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: amit(dot)kapila16(at)gmail(dot)com, Masao Fujii <masao(dot)fujii(at)gmail(dot)com>, sawada(dot)mshk(at)gmail(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jeff(dot)janes(at)gmail(dot)com, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, thom(at)linux(dot)com, memissemerson(at)gmail(dot)com, Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Support for N synchronous standby servers - take 2
Date: 2016-04-14 12:04:29
Message-ID: CAB7nPqQ3CHDGZqSsNpbw-Tyk0h=cK+zc0i-GKFrTTWk95nR1GQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 14, 2016 at 5:25 PM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
> index 3d14544..08e2acc 100644
> --- a/src/tools/msvc/vcregress.pl
> +++ b/src/tools/msvc/vcregress.pl
> @@ -548,6 +548,6 @@ sub usage
> {
> print STDERR
> "Usage: vcregress.pl ",
> -"<check|installcheck|plcheck|contribcheck|isolationcheck|ecpgcheck|upgradecheck> [schedule]\n";
> +"<check|installcheck|plcheck|contribcheck|modulescheck|ecpgcheck|isolationcheck|upgradecheck|bincheck|recoverycheck> [schedule]\n";
> exit(1);
> }

Right, this is missing modulescheck, bincheck and recoverycheck. All 3
are actually mainly my fault, or perhaps Andrew scored once on
bincheck. Honestly, this is unreadable and that's always tiring to
decrypt it, so why not changing it to something more explicit like the
attached? See by yourself:
$ perl vcregress.pl
Usage: vcregress.pl <mode> [ <schedule> ]

Options for <mode>:
bincheck run tests of utilities in src/bin/
check deploy instance and run regression tests on it
contribcheck run tests of modules in contrib/
ecpgcheck run regression tests of ECPG driver
installcheck run regression tests on existing instance
isolationcheck run isolation tests
modulescheck run tests of modules in src/test/modules
plcheck run tests of PL languages
recoverycheck run recovery test suite
upgradecheck run tests of pg_upgrade

Options for <schedule>:
serial serial mode
parallel parallel mode
--
Michael

Attachment Content-Type Size
msvc-vcregress-help.patch text/x-patch 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-04-14 12:05:40 Re: Support for N synchronous standby servers - take 2
Previous Message Ashutosh Bapat 2016-04-14 11:49:08 Re: Odd system-column handling in postgres_fdw join pushdown patch