Re: WIP: Fix parallel workers connection bug in pg_dump (Bug #13727)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: Zeus Kronion <zkronion(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: Fix parallel workers connection bug in pg_dump (Bug #13727)
Date: 2015-10-30 14:48:25
Message-ID: CAB7nPqQ2ns=_jh6PVCo4gPR6tv87FxNiQ2r14LzVNjatBiVAUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 30, 2015 at 2:42 PM, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
> On 30-10-2015 10:04, Zeus Kronion wrote:
>>
>> I'm still unclear on how to write regression tests for a connectivity
>> bug. Are they necessary in this case?
>>
> There aren't regression tests for pg_dump. However, your instructions are
> sufficient to demonstrate the bug.

Well, we could have something in pg_dump/t/, though the instance set
by standard_initdb would require some update in pg_hba.conf to switch
to md5 before running the dump.

> You could continue the thread in -bugs because the discussion started there.
> Sometimes people track -bugs ML to make sure that some bugs aren't
> forgotten. Add your patch to the next CF [1].

Yep. Things get easily lost.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-10-30 14:57:45 Re: Dangling Client Backend Process
Previous Message Alexander Korotkov 2015-10-30 14:46:59 Re: Move PinBuffer and UnpinBuffer to atomics