| From: | Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com> |
|---|---|
| To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | Bohyun Lee <bohyun(dot)lee(at)databricks(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically |
| Date: | 2026-08-17 07:44:41 |
| Message-ID: | CAB5wL7ZnL7Vty79UAbWE9_geFGu-LLYiduz_e3tPMEHW751eog@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Patch attached. I've renamed the patch file to
> v5-0001-pg_upgrade-initdb.patch to match our naming convention. No
> content change, just the filename. Happy to walk through any of this
> in more detail.
>
One more thing. While checking this against the CI build I found one
more small bug: a log message in the new --check --initdb dry-run path
had a trailing newline character it shouldn't have had, which tripped
an internal safety check and caused a crash — but only on that
stricter CI build, not on a normal build. Fixed by removing the extra
newline. v5 is now confirmed working on both build types.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-pg_upgrade-initdb.patch | application/octet-stream | 33.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 陈列行 | 2026-08-17 07:49:53 | Semantically redundant DISTINCT in an IN subquery changes the join strategy and improves execution |
| Previous Message | Michael Paquier | 2026-08-17 07:19:44 | Re: Increase repalloc_array() usage in buffile.c |