| From: | Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PSQL - improve tab completion for pub/sub options |
| Date: | 2026-08-09 08:54:55 |
| Message-ID: | CAB5wL7Y1VH3am=f+XawPgheSvjO+pvVePSsipVUPnsdt+n8H2g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> PSA patch v2.
>
Hi,
Created a v3 and issued the following topics I found.
- Fixed typo in CREATE SUBSCRIPTION block: max_rentention_duration →
max_retention_duration (was causing the TailMatches check to never
fire for that option)
- Applied pgindent to clean up indentation in the ALTER PUBLICATION
and ALTER SUBSCRIPTION SET blocks (reproduces the same fix pattern
identified in v1 review)
While reviewing, I noticed you applied the "(*)" idiom to ALTER
PUBLICATION/SUBSCRIPTION SET blocks (great fix), but the CREATE
PUBLICATION/SUBSCRIPTION blocks still use the seen_with scan. For
consistency, the same pattern could be applied there too. What is your
opinion about it?
Please see the attached v3.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-psql-tab-completion-of-pub-sub-options.patch | application/octet-stream | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-08-09 10:00:00 | Re: 019_replslot_limit.pl might fail due to checkpoint skipped |
| Previous Message | Fujii Masao | 2026-08-09 07:23:41 | Re: Random 038_walsnd_shutdown_timeout.pl failure on goldfish |