| From: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> |
|---|---|
| To: | Philip Alger <paalger0(at)gmail(dot)com> |
| Cc: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Date: | 2026-07-17 13:41:06 |
| Message-ID: | CAB-JLwb=3A=BZ02i7Vdijh9Nb0MwWZqUh2UgGMSTGoHNx4VErg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex., 17 de jul. de 2026 às 09:48, Philip Alger <paalger0(at)gmail(dot)com>
escreveu:
> Updated the pg_get_trigger_ddl() patch to align with the other
> pg_get_*_ddl functions that are committed. I moved the function out of the
> relutils.c file to the ddlutils.c file and moved the tests to TAP tests as
> well. In this patch, pretty printing is introduced and functional, similar
> to the other DDL functions.
>
Your function always returns the schema-qualified relation name, but this
will make it incompatible with pg_get_table_ddl, because that function uses
your code and might not return this way since the user could be cloning a
table to a different schema.
Therefore, I believe that all _ddl functions that work with objects
belonging to a schema should have an option to include schema-qualified or
not.
regards
Marcos
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-07-17 13:41:51 | Caching a partition index's parent OID in the relcache? |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-07-17 13:30:06 | RE: TDE: Benchmarking WAL encryption approaches |