Re: PgJDBC: code reformat

From: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
To: Dave Cramer <pg(at)fastcrypt(dot)com>
Cc: Markus KARG <markus(at)headcrashing(dot)eu>, List <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: PgJDBC: code reformat
Date: 2015-12-27 13:16:40
Message-ID: CAB=Je-GAKNkUhgnhNU+nCq0VfcvJy65=iE1soyeRzuSCmC55vg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

>I tend to break up multiple lines.

"Mandatory brackets" plus "open curly on the new line" would result in
too much whitespace.
We do want "mandatory brackets", don't we?

Regarding whitespace, what if using explicit blank lines to separate
logic when required?
Like this: https://github.com/pgjdbc/pgjdbc/blob/format_code/pgjdbc/src/main/java/org/postgresql/jdbc/PgSQLXML.java#L90-L94

>There doesn't seem to be a significant difference between sun style and google style.

Technically speaking, there is.

Sun style:

if (data == null)
{
return null;
}

Google style (this one is used by pgjdbc-ng):

if (data == null) {
return null;
}

Vladimir

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Gavin Flower 2015-12-27 14:01:22 Re: PgJDBC: code reformat
Previous Message Dave Cramer 2015-12-27 12:15:27 Re: PgJDBC: code reformat