Re: Fix overflow in justify_interval related functions

From: Joseph Koshakow <koshy44(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix overflow in justify_interval related functions
Date: 2022-02-14 21:57:07
Message-ID: CAAvxfHfaR8En08jB5sp7w-n1tv9HrBaz0wiKGRMbG1mo25yvVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 14, 2022 at 2:15 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Makes sense. So we could likely avoid it for justify_interval, but the
> others are at the mercy of the interval implementation.

I'm not entirely sure what you mean by "it", but for both
justify_interval and justify_days this commit throws an error if we
try to set the months field above 2^31.

> +SELECT justify_days(interval '2147483647 months 30 days');
> +ERROR: interval out of range
> +SELECT justify_interval(interval '2147483647 months 30 days');
> +ERROR: interval out of range

That's what these are testing.

- Joe Koshakow

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-02-14 22:06:20 Re: fixing bookindex.html bloat
Previous Message Nikolay Samokhvalov 2022-02-14 21:45:51 Re: Observability in Postgres