| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-07-08 18:38:39 |
| Message-ID: | CAAvxfHdd2ASFmGCV4XtFDC97ij9LiPY2nigOV62hqzx2MD2-Lg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 8, 2023 at 1:50 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> writes:
>> Fixed assertion in time_mi_time(). It needed to assert that the result
>> is FINITE but it was doing the other way round and that triggered some
>> failures in cfbot.
> It's still not passing in the cfbot, at least not on any non-Linux
> platforms. I believe the reason is that the patch thinks isinf()
> delivers a three-way result, but per POSIX you can only expect
> zero or nonzero (ie, finite or not).
That looks right to me. I've updated the patch to fix this issue.
Thanks,
Joe Koshakow
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Move-integer-helper-function-to-int.h-20230708.patch | text/x-patch | 3.3 KB |
| 0003-Add-infinite-interval-values-20230708.patch | text/x-patch | 96.8 KB |
| 0002-Check-for-overflow-in-make_interval-20230708.patch | text/x-patch | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joseph Koshakow | 2023-07-08 19:27:51 | Re: Infinite Interval |
| Previous Message | Joseph Koshakow | 2023-07-08 18:03:41 | Re: Preventing non-superusers from altering session authorization |