| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix overflow hazard in timestamp_pl_interval |
| Date: | 2024-04-28 03:19:52 |
| Message-ID: | CAAvxfHcVWTnP0Snh7txRm8ftZRMh7QtJxn2Fgb7zf9pprRyeew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
Immediately after sending this I realized that timestamptz suffers
from the same problem. Attached is an updated patch that fixes
timestamptz too.
Thanks,
Joe Koshakow
On Sat, Apr 27, 2024 at 10:59 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
> Hi all,
>
> Attached is a patch that fixes some overflow/underflow hazards in
> `timestamp_pl_interval`. The microseconds overflow could produce
> incorrect result. The month overflow would generally still result in an
> error from the timestamp month field being too low, but it's still
> better to catch it early.
>
> I couldn't find any existing timestamp plus interval tests so I stuck
> a new tests in `timestamp.sql`. If there's a better place, then
> please let me know.
>
> Thanks,
> Joe Koshakow
>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Catch-overflow-when-adding-timestamp-to-interval.patch | text/x-patch | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-04-28 06:59:44 | Re: partitioning and identity column |
| Previous Message | Joseph Koshakow | 2024-04-28 02:59:44 | Fix overflow hazard in timestamp_pl_interval |