Re: Avoid using raw xmin of frozen tuples in logicalrep conflict detection

From: Osama Abdul Qader <osamaabdulqaderpostgres(at)gmail(dot)com>
To: Zhijie Hou <houzhijie22(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: Avoid using raw xmin of frozen tuples in logicalrep conflict detection
Date: 2026-11-08 07:39:21
Message-ID: CAAprpiCz27-U84+=s=9U9PiP=_S5Qt=o6iY+ojOpFMAZQnQjyw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

On Sun, 8 Nov, 2026, 11:41 am Zhijie Hou, <houzhijie22(at)gmail(dot)com> wrote:

> Hi,
>
> On Sun, Nov 8, 2026 at 12:29 AM Osama Abdul Qader wrote:
> >
> > One possible approach for master would be to extend TupleTableSlotOps
> with
> > a callback such as:
> >
> > `TransactionId (*get_effective_xmin) (TupleTableSlot *slot);`
> ...
> > What do you think about introducing get_effective_xmin as a slot
> operation
> > for master?
>
> I'm afraid I find your reply quite confusing, as it is repeating the
> proposal
> I already made in my reply to Andres, without any difference I can see.
>
> Could you please read the discussion in this thread carefully and
> share your thoughts after considering it? If you're using AI to help
> draft replies, please review and understand the output fully before
> sending it.
>
> --
> Best Regards,
> Zhijie Hou
>

Thank you for pointing this out, I repeat the proposal of
get_effective_xmin callback approach, I apologize for the confusion I
caused here.

I'd be interested in helping with the implementation and further
investigation of this approach. In particular, I can examine the callback's
behavior across the different TupleTableSlotOps implementations, identify
any edge cases around frozen tuples and invalid transaction IDs, and work
on regression tests.

I'd also like to understand the compatibility constraints for the backpatch
branches and how the proposed master implementation should differ from them.

If useful, I'd be happy to take on this implementation work and submit a
patch for review.

Best regards,
Osama Abdul Qader.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-11-08 07:49:50 Re: Compression of bigger WAL records
Previous Message Andrey Borodin 2026-11-08 07:23:12 Re: amcheck: add index-all-keys-match verification for B-Tree