Re: [PATCH] Add memory/disk usage for Function Scan nodes in EXPLAIN

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Yash Jadhav <yash(dot)jadhav8008(at)gmail(dot)com>
Cc: Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add memory/disk usage for Function Scan nodes in EXPLAIN
Date: 2026-10-08 20:59:03
Message-ID: CAApHDvryup7hxvxqpvtMpTRuWR0q62zC7qWnAG6Sp_zTsaBtYQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 9 Oct 2026 at 08:00, Yash Jadhav <yash(dot)jadhav8008(at)gmail(dot)com> wrote:
> For now I understand that for each rerun, a new tuple store would be
> obtained along with new stats, and that it would mean changing srf
> calling convention in order for the swap to work, but that would mean
> a big change. I have also tried to understand the relevant code path.
>
> So I wanted to try if I could find a way to solve this, as a
> first-time contributor, I'd appreciate any feedback on whether my
> understanding is correct, and whether changing the calling convention
> is the only way here.

Switching to tuplestore_clear() is welcome for other reasons. There's
been no benchmarking done on this thread for it, but see the reported
performance gains mentioned in the commit message [1].

This may be an argument for doing the tuplestore_clear() change as a
separate commit.

David

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=908a9686

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Ayoub Kazar 2026-10-08 20:39:10 Re: [PROPOSAL] Expand OR clauses in joins to UNION ALL paths